Skip to content

remove check of existence of property defaultMessage in isValidMessage #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2019
Merged

remove check of existence of property defaultMessage in isValidMessage #40

merged 1 commit into from
Dec 16, 2019

Conversation

@ilan-schemoul
Copy link
Contributor

@ilan-schemoul ilan-schemoul commented Dec 14, 2019

fix #39
As defaultMessage is NOT required, the function isValidMessage should not check for defaultMessage existence.

@ilan-schemoul ilan-schemoul mentioned this pull request Dec 14, 2019
Closed
@BANG88 BANG88 merged commit e4c6c7c into BANG88:master Dec 16, 2019
@BANG88
Copy link
Owner

BANG88 commented Dec 16, 2019

0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not parsing FormattedMessage if no defaultMessage is defined

2 participants

@ilan-schemoul @BANG88