Fix T4 GPU TypeError in CuPy CG solver and Tutorial 2, 4 and 7 CPU install#247
Merged
jameslehoux merged 2 commits intomasterfrom Apr 9, 2026
Merged
Fix T4 GPU TypeError in CuPy CG solver and Tutorial 2, 4 and 7 CPU install#247jameslehoux merged 2 commits intomasterfrom
jameslehoux merged 2 commits intomasterfrom
Conversation
The CuPy sparse CG solver renamed its tolerance parameter from `tol` to `rtol` in newer versions (mirroring scipy >= 1.12). Add try/except fallback matching the existing scipy compatibility pattern. Tutorial 2 hardcoded `openimpala-cuda` in the install cell, which fails silently on CPU-only Colab runtimes. Auto-detect GPU via nvidia-smi and fall back to the CPU package when no GPU is present. https://claude.ai/code/session_01BXGy2knFzA2bgVnuNRNVVQ
Same issue as tutorial 02: hardcoded `openimpala-cuda` install fails silently on CPU-only Colab runtimes. Use nvidia-smi detection to fall back to the CPU package when no GPU is present. https://claude.ai/code/session_01BXGy2knFzA2bgVnuNRNVVQ
Performance Benchmark Results
Fastest solver: bicgstab at 64³ (0.4130s) Benchmark: uniform block (analytical τ = (N-1)/N) |
Code Coverage ReportGenerated by CI — coverage data from gcovr |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CuPy sparse CG solver renamed its tolerance parameter from
toltortolin newer versions (mirroring scipy >= 1.12). Add try/exceptfallback matching the existing scipy compatibility pattern.
Tutorial 2 hardcoded
openimpala-cudain the install cell, which failssilently on CPU-only Colab runtimes. Auto-detect GPU via nvidia-smi and
fall back to the CPU package when no GPU is present.