tutorial 01: handle ConvergenceError in parametric sweep#250
Merged
jameslehoux merged 1 commit intomasterfrom Apr 17, 2026
Merged
tutorial 01: handle ConvergenceError in parametric sweep#250jameslehoux merged 1 commit intomasterfrom
jameslehoux merged 1 commit intomasterfrom
Conversation
Random NumPy fallback microstructures (no PoreSpy) can produce pathologically thin percolating paths at low porosity that cause the HYPRE solver to hit its iteration limit. Catch oi.ConvergenceError and skip those points with a message, matching how non-percolating cases are already handled. Also switch the fallback generator to numpy.random.default_rng seeded per-porosity for reproducibility. https://claude.ai/code/session_01BXGy2knFzA2bgVnuNRNVVQ
Code Coverage ReportGenerated by CI — coverage data from gcovr |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Random NumPy fallback microstructures (no PoreSpy) can produce pathologically thin percolating paths at low porosity that cause the HYPRE solver to hit its iteration limit. Catch oi.ConvergenceError and skip those points with a message, matching how non-percolating cases are already handled. Also switch the fallback generator to numpy.random.default_rng seeded per-porosity for reproducibility.