drop redundant strip+repack pass — auditwheel --strip already handles…#266
Merged
jameslehoux merged 1 commit intomasterfrom Apr 29, 2026
Merged
drop redundant strip+repack pass — auditwheel --strip already handles…#266jameslehoux merged 1 commit intomasterfrom
jameslehoux merged 1 commit intomasterfrom
Conversation
… _core.so
Confirmed from the previous build log:
INFO:auditwheel.repair:Stripping symbols from openimpala/_core.cpython-312-x86_64-linux-gnu.so
auditwheel --strip strips the main extension module too, not just the
vendored libs. My earlier assumption was wrong, and the custom unpack /
strip / `wheel pack` post-pass was redundant — and broke at runtime
because the cibuildwheel-runtime python doesn't have the `wheel` package
installed (it's only in the build venv).
The wheel landed at 259 MiB after the arch trim + auditwheel --strip,
comfortably under PyPI's 320 MiB ceiling for openimpala-cuda. Drop the
custom pass and write directly to {dest_dir}.
https://claude.ai/code/session_011dJ5Bwq4Tnr8wxH597XJFf
Code Coverage ReportGenerated by CI — coverage data from gcovr |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… _core.so
Confirmed from the previous build log:
auditwheel --strip strips the main extension module too, not just the vendored libs. My earlier assumption was wrong, and the custom unpack / strip /
wheel packpost-pass was redundant — and broke at runtime because the cibuildwheel-runtime python doesn't have thewheelpackage installed (it's only in the build venv).The wheel landed at 259 MiB after the arch trim + auditwheel --strip, comfortably under PyPI's 320 MiB ceiling for openimpala-cuda. Drop the custom pass and write directly to {dest_dir}.