Document custom staging domain#106
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Playwright Hosted Data-FlowOutcome: success This optional check runs the mutation-backed profile flow against a configured hosted dev/staging target with isolated E2E test data. |
Playwright Data-Flow PreviewOutcome: success Captured flow:
Artifacts include screenshots, traces, and recorded video for the flow run. |
Playwright Public Screenshot PreviewOutcome: success Screenshots: all public route checks passed on desktop and mobile. Full screenshot set is available in the artifact. Pixel diff baselines are handled by the separate Playwright Image Diff check. |
Playwright Image DiffOutcome: success Changed screenshot baselines: none in this PR. This check compares public route screenshots against committed baselines. Inline images show only added or modified baseline PNGs. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Greptile SummaryThis PR records
Confidence Score: 4/5Safe to merge — documentation changes are accurate and declarative, and the readiness-poll logic is well-structured with configurable knobs. The only code change is the new waitForFunctionsReady loop, which is straightforward and was validated by a passing CI run. A runConvex helper is introduced but never wired up, leaving dead code and the syncEnvVarsOnce calls without the 10 s timeout that helper would have provided. scripts/sync-convex-local-env.mjs — the unused runConvex function should either replace the inline spawnSync calls in syncEnvVarsOnce or be removed. Important Files Changed
Sequence DiagramsequenceDiagram
participant PW as Playwright / CI
participant Script as sync-convex-local-env.mjs
participant CH as ConvexHttpClient
participant Conv as Local Convex (127.0.0.1)
PW->>Script: node scripts/sync-convex-local-env.mjs
Script->>CH: new ConvexHttpClient(localConvexUrl)
loop Poll every 500 ms (up to 180 s)
CH->>Conv: "query("health:status", {})"
alt functions ready
Conv-->>CH: result
CH-->>Script: return true
else not ready yet
Conv-->>CH: error
Script->>Script: sleep(readyPollMs)
end
end
alt timeout
Script-->>PW: process.exit(1)
else ready
Script->>Conv: spawnSync convex env set ... (syncEnvVarsOnce)
Script-->>PW: process.exit(0)
end
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
scripts/sync-convex-local-env.mjs:52-60
The `runConvex` helper is introduced in this PR but never called — `syncEnvVarsOnce` still invokes `spawnSync` inline. Either wire it up to replace the inline call (which would also gain the `timeout: 10_000` guard) or remove it to keep the file clean.
```suggestion
// runConvex helper removed — syncEnvVarsOnce uses spawnSync inline.
// Restore and wire up here if you want the 10 s timeout applied to env-set calls.
```
Reviews (1): Last reviewed commit: "Wait for Convex functions before Playwri..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| function runConvex(args) { | ||
| return spawnSync(convexBin, args, { | ||
| cwd: repoRoot, | ||
| encoding: "utf8", | ||
| env: convexEnv(), | ||
| shell: process.platform === "win32", | ||
| timeout: 10_000, | ||
| }); | ||
| } |
There was a problem hiding this comment.
runConvex helper is introduced in this PR but never called — syncEnvVarsOnce still invokes spawnSync inline. Either wire it up to replace the inline call (which would also gain the timeout: 10_000 guard) or remove it to keep the file clean.
| function runConvex(args) { | |
| return spawnSync(convexBin, args, { | |
| cwd: repoRoot, | |
| encoding: "utf8", | |
| env: convexEnv(), | |
| shell: process.platform === "win32", | |
| timeout: 10_000, | |
| }); | |
| } | |
| // runConvex helper removed — syncEnvVarsOnce uses spawnSync inline. | |
| // Restore and wire up here if you want the 10 s timeout applied to env-set calls. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: scripts/sync-convex-local-env.mjs
Line: 52-60
Comment:
The `runConvex` helper is introduced in this PR but never called — `syncEnvVarsOnce` still invokes `spawnSync` inline. Either wire it up to replace the inline call (which would also gain the `timeout: 10_000` guard) or remove it to keep the file clean.
```suggestion
// runConvex helper removed — syncEnvVarsOnce uses spawnSync inline.
// Restore and wire up here if you want the 10 s timeout applied to env-set calls.
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
What changed
Testing
git diff --checknode --check scripts/sync-convex-local-env.mjspnpm --filter web exec playwright test e2e/public-routes.visual.spec.ts --grep "server-status" --project=desktop-chromiumRisk
Docs are declarative. The script change only affects local Convex/Playwright startup sequencing and keeps the existing local deployment/env-sync behavior.