fix: restore /games public access and add missing company.write.linked capability#30
Merged
Conversation
…d capability - Add /games to middleware publicPaths so ping pong game is accessible without authentication - Add company.write.linked to Capability union type and company role capabilities array - Add as Route casts for /company/contacts and /company/stores nav items Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughFour coordinated changes extend the auth system with a new company capability ( ChangesAuth capability and public route configuration
Possibly related PRs
🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/gamesto middlewarepublicPathsso the ping pong game is accessible without authenticationcompany.write.linkedtoCapabilityunion type (fixes type errors from PR [STU-106] Add company contacts and stores management pages #25 where this capability was referenced incompany/actions.tsbut never defined)company.write.linkedto company role's capabilities arrayas Routecasts for/company/contactsand/company/storesnavigation itemsWhy
These 4 fixes were applied during the STU-96 ping pong game deployment but were repeatedly reverted by lint-staged/husky pre-commit hooks. Without them:
/games/ping-pongreturns HTTP 307 (redirects to login)npx tsc --noEmitfails with 4company.write.linkedtype errors/company/contactsand/company/storesroutesTest plan
npx tsc --noEmitpasses with zero errors/games/ping-pongloads without auth/company/contactsand/company/storesnav links work🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Improvements