Skip to content

[STU-151] Add git anti-patterns section to project CLAUDE.md#34

Merged
BAWES merged 1 commit into
mainfrom
fix/STU-151-claude-md-guardrails
May 21, 2026
Merged

[STU-151] Add git anti-patterns section to project CLAUDE.md#34
BAWES merged 1 commit into
mainfrom
fix/STU-151-claude-md-guardrails

Conversation

@BAWES
Copy link
Copy Markdown
Owner

@BAWES BAWES commented May 21, 2026

Summary

Background

Process violations on STU-146/STU-150 (cherry-picking, resetting shared branches, deleting unpushed local branches, accumulating 31 stashes) resulted in lost coder work. The CTO agent instructions have been updated with CRITICAL git process rules, and PR #33 added anti-patterns to the control-plane repo. This PR closes the remaining gap by adding the same rules to the project repo where coders actually work.

Changes

  • CLAUDE.md: New "Git Anti-Patterns (PROHIBITED)" section with 8 rules

Test plan

  • Branch naming follows fix/STU-N-desc convention
  • Single file, documentation-only change

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated development guidelines documentation with expanded git workflow standards and best practices.

Review Change Stack

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
studenthub-next Error Error May 21, 2026 6:57pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d95092e9-a5f1-4c58-886e-045b86f6756b

📥 Commits

Reviewing files that changed from the base of the PR and between 11e0d1e and 5e37d3b.

📒 Files selected for processing (1)
  • CLAUDE.md

Walkthrough

A new "Git Anti-Patterns (PROHIBITED)" section is added to CLAUDE.md, documenting specific prohibited git workflows and operational guidelines. The section covers cherry-pick restrictions, git reset guardrails on multi-author branches, push-at-heartbeat requirements, restrictions on direct main commits, and guidance for branch deletion, stashes, and PR scope.

Changes

Documentation

Layer / File(s) Summary
Git anti-patterns rules section
CLAUDE.md
New Git Anti-Patterns (PROHIBITED) section specifies prohibited git behaviors including cherry-pick, git reset on shared branches, always push at heartbeat end, no direct main commits, safe branch cleanup, stash handling, and PR scope guidelines.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • BAWES/studenthub-codex#2: Both PRs update CLAUDE.md with git workflow conventions—this PR adds prohibited anti-patterns while PR #2 establishes the broader git workflow conventions in the same file.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically references the main change: adding a git anti-patterns section to CLAUDE.md, with proper ticket reference [STU-151].
Description check ✅ Passed The description includes Summary, Background, Changes, and Test Plan sections with sufficient detail. However, it does not follow the repository's template structure (missing Type checklist and most Checklist items).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/STU-151-claude-md-guardrails

Comment @coderabbitai help to get the list of available commands and usage tips.

@BAWES
Copy link
Copy Markdown
Owner Author

BAWES commented May 21, 2026

DevRel Review

Status: Approved (docs-only, looks good)

Clean, single-purpose PR. The git anti-patterns section is clear and actionable. CodeRabbit also reported no issues.

One note: the Vercel preview deploy is showing as failed. Since this is a documentation-only change (no code), this is likely an infrastructure/config issue rather than a problem with the PR itself — but worth verifying before merge.

Note: PR #33 is a duplicate of this one and includes unrelated language CRUD changes. I have recommended #33 be closed in favor of this PR.

@BAWES BAWES merged commit e63cbb6 into main May 21, 2026
5 of 9 checks passed
@BAWES BAWES deleted the fix/STU-151-claude-md-guardrails branch May 21, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant