Use of Catkin locate to make scripts more flexible #212 #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tkin locate and outside using dirname Testing: From home you could run `./SwarmBaseCode-ROS/run.sh` this will use dirname From SwarmBaseCode-ROS/src/behaviours/src you could run it as ../../../run.sh this will use catkin locate
…e repo using catkin locate and outside using dirname
wfvining
suggested changes
Dec 3, 2018
| cd .. | ||
| dirPath="$(pwd)" | ||
| dirName="$(basename `pwd`)" | ||
| export dirPath="$(catkin locate)" |
Contributor
There was a problem hiding this comment.
Does this need to be exported to the environment?
Suggested change
| export dirPath="$(catkin locate)" | |
| dirPath="$(catkin locate)" |
| @@ -1,3 +1,5 @@ | |||
| #!/bin/bash | |||
| export SWARMATHON_APP_ROOT="$(catkin locate)" | |||
Contributor
There was a problem hiding this comment.
ditto
Suggested change
| export SWARMATHON_APP_ROOT="$(catkin locate)" | |
| SWARMATHON_APP_ROOT="$(catkin locate)" |
| export GAZEBO_MODEL_PATH="$PWD/simulation/models" | ||
| export GAZEBO_PLUGIN_PATH="$PWD/build/gazebo_plugins" | ||
| source "$PWD/devel/setup.bash" | ||
| export SWARMATHON_APP_ROOT="$(catkin locate)" |
Contributor
There was a problem hiding this comment.
ditto
Suggested change
| export SWARMATHON_APP_ROOT="$(catkin locate)" | |
| SWARMATHON_APP_ROOT="$(catkin locate)" |
mike-matera
pushed a commit
to mike-matera/SwarmBaseCode-ROS
that referenced
this pull request
Dec 31, 2019
Filter out poorly detected home tags during find home corner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for issue #212 @wfvining
I alas do not have a Swarmie this turkey day eve, so I am unable to test.
Testing the run.sh changes:
From home you could run
./SwarmBaseCode-ROS/run.shthis will use dirnameFrom SwarmBaseCode-ROS/src/behaviours/src you could run it as ../../../run.sh this will use catkin locate
And essentially the same for both
misc/deploy.sh
misc/rover_launch_local.sh