[Business][feature] 결제 완료 화면 WebApp bridge 구현#1024
Merged
KYM-P merged 3 commits intodevelop-businessfrom Sep 14, 2025
Merged
Conversation
Add webapp bridge in webs orderpage
Add webapp bridge test class
Feat ktlint
kongwoojin
approved these changes
Sep 14, 2025
Member
kongwoojin
left a comment
There was a problem hiding this comment.
고생하셨습니다
몇가지만 확인 해주시고 머지 하시면 될 것 같습니다
| import `in`.koreatech.koin.core.webapp.KoinWebAppWebChromeClient | ||
| import `in`.koreatech.koin.core.webapp.KoinWebAppWebViewClient | ||
|
|
||
| class WebAppBridgeTest { |
Collaborator
Author
There was a problem hiding this comment.
사실 남겨야하나 고민했는데
webview 를 junit 에서 구동할 수도 없어서
해당 객체를 만들고 실제 activity 에서 복붙해서 테스트 하는 용도로 사용했습니다.
html 코드로 실험해볼까 해서 만들었습니다.
테스트 코드보단 테스트 객체일 뿐이라서... 제거할까요?
| } | ||
|
|
||
| internal class StorePaymentScreenInterface( | ||
| private val navigateDetail: (Int) -> Unit, |
Member
There was a problem hiding this comment.
navigateToDetail로 맞춰도 될 것 같습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 개요
이슈 번호: #1023
PR 체크리스트
작업사항
작업사항의 상세한 설명
기존
StorePaymentScreenInterface구현부에를 추가로 선언하여
webapp bridge 를 만들었습니다.
추가적으로 JavascriptInterface 의 내부 실행이 background thread 에서 실행될 수 있어서
기존 방식에 따라
(context as Activity).runOnUiThread을 통해 Ui thread 로 고정했습니다.논의 사항
현재 누르면 다른 가게로 가는데 이건 이야기 해보겠습니다.
스크린샷
추가내용