Skip to content

[User][Feature] Custom session id 기반 회원가입 진입 로깅 추가#1102

Merged
JaeYoung290 merged 4 commits intofeature/#1099-implement-swipe-delete-in-dining-ab-test-buttonfrom
feature/#1101-add-custom-session-id-logging-in-signup
Oct 12, 2025
Merged

[User][Feature] Custom session id 기반 회원가입 진입 로깅 추가#1102
JaeYoung290 merged 4 commits intofeature/#1099-implement-swipe-delete-in-dining-ab-test-buttonfrom
feature/#1101-add-custom-session-id-logging-in-signup

Conversation

@JaeYoung290
Copy link
Copy Markdown
Contributor

@JaeYoung290 JaeYoung290 commented Oct 11, 2025

PR 개요

이슈 번호: #1101

PR 체크리스트

  • Code convention을 잘 지켰나요?
  • Lint check를 수행하였나요?
  • Assignees를 추가했나요?

작업사항

  • 버그 수정
  • 신규 기능
  • 코드 스타일 수정 (포맷팅 등)
  • 리팩토링 (기능 수정 X, API 수정 X)
  • 기타

작업사항의 상세한 설명

  • custom session id 기반으로 회원가입 진입 로깅을 출력하도록 수정하였습니다.

논의 사항

스크린샷

추가내용

  • develop, sprint 브랜치를 향하고 있습니다
  • production 브랜치를 향하고 있습니다

@JaeYoung290 JaeYoung290 self-assigned this Oct 11, 2025
@JaeYoung290 JaeYoung290 requested a review from a team as a code owner October 11, 2025 15:59
@github-actions github-actions Bot requested review from KYM-P and kongwoojin October 11, 2025 15:59
@JaeYoung290 JaeYoung290 changed the title Feature/#1101 add custom session id logging in signup [User][Feature] Custom session id 기반 회원가입 진입 로깅 추가 Oct 11, 2025
@github-actions github-actions Bot added the user BCSD user team label Oct 11, 2025
@JaeYoung290 JaeYoung290 changed the base branch from develop to feature/#1099-implement-swipe-delete-in-dining-ab-test-button October 11, 2025 16:00
Copy link
Copy Markdown
Member

@kongwoojin kongwoojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
추후 머지되기 전에 DA 분과 로깅 검수 진행 하시면 될 것 같습니다


val context = LocalContext.current

var sessionId by remember { mutableStateOf("") }
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viewModel에 sessionId를 저장할 수는 없을까요?

Copy link
Copy Markdown
Contributor Author

@JaeYoung290 JaeYoung290 Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!

Copy link
Copy Markdown
Member

@kongwoojin kongwoojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생하셨습니다!

@JaeYoung290 JaeYoung290 merged commit 27c0362 into feature/#1099-implement-swipe-delete-in-dining-ab-test-button Oct 12, 2025
1 check passed
@JaeYoung290 JaeYoung290 deleted the feature/#1101-add-custom-session-id-logging-in-signup branch October 12, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature user BCSD user team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants