Skip to content

Conversation

@TTRR1007
Copy link
Contributor

@TTRR1007 TTRR1007 commented Jan 22, 2026

PR 개요

이슈 번호:

PR 체크리스트

  • Code convention을 잘 지켰나요?
  • Lint check를 수행하였나요?
  • Assignees를 추가했나요?

작업사항

  • 버그 수정
  • 신규 기능
  • 코드 스타일 수정 (포맷팅 등)
  • 리팩토링 (기능 수정 X, API 수정 X)
  • 기타

작업사항의 상세한 설명

Campus API의 분실물 게시글 수정 api 추가하였습니다

논의 사항

스크린샷

추가내용

  • develop, sprint 브랜치를 향하고 있습니다
  • production 브랜치를 향하고 있습니다

@TTRR1007 TTRR1007 requested a review from a team as a code owner January 22, 2026 08:16
@TTRR1007 TTRR1007 self-assigned this Jan 22, 2026
@github-actions github-actions bot added feature campus BCSD campus ream labels Jan 22, 2026
@github-actions github-actions bot requested review from KYM-P and kongwoojin January 22, 2026 08:16
Copy link
Member

@kongwoojin kongwoojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
먼저 lint 수정해주세요

400 -> KoinArticleException.CanNotFoundItemException()
401 -> KoinArticleException.UnauthorizedUserException()
403 -> KoinArticleException.ForbiddenAuthor()
404 -> KoinArticleException.NotFoundImage()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

게시글 수정 API인데 404일 경우 NotFoundImage Exception이네요
확인 부탁드립니다.

Copy link
Contributor Author

@TTRR1007 TTRR1007 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404

Swagger UI에서 '404 이미지를 찾을 수 없습니다'로 나타나서 저렇게 작성했습니다!

Copy link
Member

@kongwoojin kongwoojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생하셨습니다

@kongwoojin
Copy link
Member

lint 실패했네요 수정하고 머지해주세요

@TTRR1007 TTRR1007 merged commit d9aa849 into feature/lostandfound-base Jan 22, 2026
1 check passed
@TTRR1007 TTRR1007 deleted the feature/#1214-lostandfound-article-api-add branch January 22, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

campus BCSD campus ream feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants