Merged
Conversation
ImTotem
requested review from
Choi-JJunho,
Choon0414,
dradnats1012 and
songsunkook
- ms -> yyyy-MM-dd
songsunkook
approved these changes
Mar 19, 2024
Contributor
songsunkook
left a comment
songsunkook
left a comment
There was a problem hiding this comment.
깔끔하게 잘 작성해주셨네요. 다들 고생하셨습니다!
컨트롤러 분리 관련해서 코멘트 남겨드렸는데 의견 부탁드립니다!
Comment on lines
+20
to
+21
| @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd", timezone = "Asia/Seoul") | ||
| private Date updatedAt; |
Contributor
There was a problem hiding this comment.
A
레거시는 엔티티 클래스에 Date를 사용하는군요... 🥲
Comment on lines
+17
to
+20
| @Api(tags = "(Normal) Bus V2", description = "버스 V2") | ||
| @Controller | ||
| @RequestMapping(value = "v2/bus") | ||
| public class V2BusController { |
Contributor
There was a problem hiding this comment.
C
컨트롤러까지 분리해야 할까요?? 개인적으로는 기존 컨트롤러에 붙여도 된다고 생각합니다만, 어떤 이유로 분리하신 것인지 궁금합니다.
Contributor
There was a problem hiding this comment.
timetable 관련만 바뀌었다보니 controller를 분리할 필요까지는 없어보여 합쳤습니다
고민한 부분은 bus/v2/timetable 과 bus/tiimetable/v2중 어떤게 나을까 고민하다가 전자는 /bus가 전체적으로 바꼈다는 느낌을 줄 수 있을것 같아서 timetable만 바꼈다는 느낌이 들도록 후자를 선택하게 되었습니다!
Co-authored-by: dradnats1012 <herjebi1012@gmail.com> Co-authored-by: Choon0414 <hyunn815@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
▶ Request
Content
as-is
버스 시간표 업데이트 시간 보여주기
to-be
v2 bus에 updated_at dto 추가
✅ Check List
pom.xml) 변경이 일어나지 않았는지📸 API Document ScreenShot
🧪 Test
로컬에서 테스트