feat: UserAgentArgumentResolver iOS 판별 추가#1603
Merged
Merged
Conversation
This reverts commit 8f72799.
BaeJinho4028
approved these changes
Jun 2, 2025
| if (userAgent.toLowerCase().contains(indicator.toLowerCase())) { | ||
| return "Mobile"; | ||
| } | ||
| String[] mobileIndicators = {"Mobile", "Mobi", "Android", "iPhone", "iOS", "Windows Phone"}; |
Collaborator
There was a problem hiding this comment.
이건 클라이언트에서 판독해서 주는건가? 맞나?
Collaborator
Author
There was a problem hiding this comment.
웹은 모르겠는데, 안드랑 ios는 직접 설정한 값으로 주는 거 같아요
Soundbar91
commented
Jun 2, 2025
Collaborator
Author
Soundbar91
left a comment
Soundbar91
left a comment
There was a problem hiding this comment.
맞습니다.
IOS는 해당 PR 머지되면 강업이 없어도 식별이 되는데, 안드의 경우 이번에 작업을 해주셔서, 업데이트가 안된 유저의 경우 식별이 안 되서 강업 이후에 된다고 합니다 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항