chore: 분실물 진입점 수정#341
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the lost item entry point from the notice board list and updates the deep link logic to navigate directly to the dedicated LostItemListViewController instead of the notice board view.
Changes:
- Removed the
lostItemcase from theNoticeListTypeenum and adjusted the indices of remaining cases - Removed the write button visibility logic that was specific to the lost item notice type
- Updated deep link handling to use
LostItemListViewControllerinstead ofNoticeListViewControllerwhen navigating to/articles/lost-item
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Koin/Domain/Model/NoticeList/NoticeListType.swift | Removed lostItem enum case and adjusted indices for remaining cases (all shifted down by 1) |
| Koin/Presentation/Notice/NoticeList/NoticeListViewController.swift | Removed write button visibility logic that was conditional on lostItem notice type |
| Koin/Apps/SceneDelegate.swift | Updated deep link handling in two methods to instantiate LostItemListViewController with proper dependencies instead of NoticeListViewController |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let userRepository = DefaultUserRepository(service: DefaultUserService()) | ||
| let lostItemRepository = DefaultLostItemRepository(service: DefaultLostItemService()) | ||
| let checkLoginUseCase = DefaultCheckLoginUseCase(userRepository: userRepository) | ||
| let fetchLostItemItemUseCase = DefaultFetchLostItemListUseCase(repository: lostItemRepository) | ||
| let viewModel = LostItemListViewModel(checkLoginUseCase: checkLoginUseCase, fetchLostItemListUseCase: fetchLostItemItemUseCase) | ||
| let viewController = LostItemListViewController(viewModel: viewModel) |
There was a problem hiding this comment.
There's code duplication between handleIncomingDeepLink (lines 36-41) and the scene continue userActivity method (lines 53-58). Both create identical instances of the same repositories, use cases, view model, and view controller. Consider extracting this duplicated logic into a private helper method to improve maintainability and reduce code duplication.
#️⃣연관된 이슈
📝작업 내용
분실물 진입점을 수정했습니다.
스크린샷 (선택)
💬리뷰 요구사항(선택)