chore: 홈화면 abTest 로직 제거#355
Merged
hgjwilly-koreatech merged 7 commits intodevelopfrom Feb 2, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes ended AB test logic from the home screen, simplifying the codebase by eliminating conditional feature branching and settling on the chosen variants.
Changes:
- Removed AB test use case dependency from HomeViewModel and related view controllers
- Simplified banner display to always use BannerViewControllerA (bottom sheet variant)
- Replaced dynamic club display logic (AB tested between hot clubs and categories) with direct hot club fetching
- Removed AB test-specific analytics events while preserving essential user interaction logging
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| HomeViewModel.swift | Removed AB test-related input/output cases, use case dependency, and conditional logic; added direct fetchHotClub call on viewDidLoad |
| HomeViewController.swift | Simplified banner display to use only variant A, removed AB test result handling and related analytics events |
| LoginViewController.swift | Removed assignAbTestUseCase parameter from HomeViewModel initialization |
| ChangePasswordSuccessViewController.swift | Removed assignAbTestUseCase parameter from HomeViewModel initialization |
| FoundIdViewController.swift | Removed assignAbTestUseCase parameter from HomeViewModel initialization |
| ForceModifyUserViewController.swift | Removed assignAbTestUseCase parameter from HomeViewModel initialization |
| SceneDelegate.swift | Removed assignAbTestUseCase parameter from HomeViewModel initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| private func fetchClubCategories() { | ||
| print(#function) |
There was a problem hiding this comment.
Debug print statement should be removed. This appears to be leftover debugging code that was added during the AB test removal refactoring.
Suggested change
| print(#function) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
홈화면에서 종료된 abTest 로직을 제거했습니다.
스크린샷 (선택)
💬리뷰 요구사항(선택)