Skip to content

Creation of Declared Status for Interested Students in CCE Minor#1421

Merged
bledsoef merged 23 commits intodevelopmentfrom
markInterestedAsDeclaredCCEMinor-1420
Apr 3, 2025
Merged

Creation of Declared Status for Interested Students in CCE Minor#1421
bledsoef merged 23 commits intodevelopmentfrom
markInterestedAsDeclaredCCEMinor-1420

Conversation

@stevensonmichel
Copy link
Copy Markdown
Contributor

@stevensonmichel stevensonmichel commented Mar 4, 2025

Issue Description

Previously, if a student expressed interest for minor, they will be recorded and showed on the minor page of the admin, with a table having the option to remove students. However, a new concept declared students begin as a student affirms and declared his intention to fulfill a minor. This new concept is not reflected in the old system.

Fixes #1420
Thus, the creation of a new status for Minor Candidates becomes necessary, with the two status being Interested and Declared. This innovation calls for changes from the databases and the backend all the way to the frontend.

Changes

  • Created routes allowing admins to update interested students into declared students.
  • Designed and implemented tabs keeping track of interested and declared students.
  • Added a new column - declaredMinor - in the User table.
  • Allowed the admin to email Interested Students, Declared Students, or Both Groups.

Additional Fixes

  • Refactor the process for deleting Interested students.
  • Fix delete button for Interested and Declared Students.

Testing

  • Use the local or containerized methods to run the app.
  • On the sidebar, click on Admin - which is a dropdown.
  • On the dropdown, go to Minor Management.
  • Notice the changes at the bottom of the page, under CCE MINOR CANDIDATES with the tabs Interested and Declared.
  • Pay attention to the behavior of the dropdown button Email All, along with the dropdown options execution.
  • Play with Deleting and Adding students, as a major refactor occurred in these areas.
  • In addition, run tests with and watch closely test_minor.py

Images

1- BEFORE (MINOR MANAGEMENT PAGE)

Screenshot 2025-03-05 113830

2- AFTER (MINOR MANAGEMENT PAGE WITH FOCUS ON INTERESTED TAB)

Screenshot 2025-03-05 113512

3- AFTER (MINOR MANAGEMENT PAGE WITH FOCUS ON DECLARED TAB)

Screenshot 2025-03-05 113531

Enjoy !!!!

@stevensonmichel stevensonmichel self-assigned this Mar 5, 2025
Copy link
Copy Markdown
Contributor

@WackyWeaver WackyWeaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but ping me to approve after those little fixes with the blank function and print statement.

Comment thread app/controllers/admin/minor.py Outdated
Comment thread app/static/js/minorAdminPage.js Outdated
Comment thread app/templates/admin/cceMinor.html Outdated
Comment thread app/templates/admin/cceMinor.html Outdated
Comment thread app/templates/admin/cceMinor.html
Comment thread app/templates/admin/cceMinor.html Outdated
Comment thread app/templates/admin/cceMinor.html Outdated
ojmakinde
ojmakinde previously approved these changes Mar 25, 2025
Copy link
Copy Markdown
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of nitpicks here, but really solid job. Lets go over it tomorrow together because I have a few comments I want to talk through with you.

One other thing not included in the comments. I would like it if when removing a student from the Declared tab it kept you on the Declared tab, same with moving. This likely will need to be passed in via the url parameters so you can pull it down and see which tab you need to be on with ?tab=Declared or something like that.

Comment thread app/controllers/admin/minor.py Outdated
Comment thread app/logic/minor.py Outdated
Comment thread app/static/js/minorAdminPage.js Outdated
Comment thread app/static/js/minorAdminPage.js Outdated
Comment thread app/static/js/minorAdminPage.js Outdated
Comment thread tests/code/test_minor.py
Comment thread tests/code/test_minor.py Outdated
Comment thread app/templates/admin/cceMinor.html Outdated
Comment thread app/templates/admin/cceMinor.html Outdated
Comment thread app/templates/admin/cceMinor.html
Comment thread app/templates/admin/cceMinor.html
Copy link
Copy Markdown
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functionality is excellent!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2025

View Code Coverage

@bledsoef bledsoef merged commit ca7f19c into development Apr 3, 2025
5 checks passed
@bledsoef bledsoef deleted the markInterestedAsDeclaredCCEMinor-1420 branch April 3, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark Interested Students as Declared for CCE Minor

4 participants