Creation of Declared Status for Interested Students in CCE Minor#1421
Merged
bledsoef merged 23 commits intodevelopmentfrom Apr 3, 2025
Merged
Creation of Declared Status for Interested Students in CCE Minor#1421bledsoef merged 23 commits intodevelopmentfrom
bledsoef merged 23 commits intodevelopmentfrom
Conversation
WackyWeaver
reviewed
Mar 17, 2025
Contributor
WackyWeaver
left a comment
There was a problem hiding this comment.
Looks good, but ping me to approve after those little fixes with the blank function and print statement.
…so made style changes in a few locations to match CELTS styling convention
ojmakinde
reviewed
Mar 20, 2025
ojmakinde
reviewed
Mar 20, 2025
ojmakinde
reviewed
Mar 20, 2025
ojmakinde
reviewed
Mar 20, 2025
ojmakinde
reviewed
Mar 25, 2025
ojmakinde
previously approved these changes
Mar 25, 2025
…ts into markInterestedAsDeclaredCCEMinor-1420
…StudentSoftwareDevTeam/celts into markInterestedAsDeclaredCCEMinor-1420
bledsoef
requested changes
Apr 2, 2025
Contributor
bledsoef
left a comment
There was a problem hiding this comment.
Lots of nitpicks here, but really solid job. Lets go over it tomorrow together because I have a few comments I want to talk through with you.
One other thing not included in the comments. I would like it if when removing a student from the Declared tab it kept you on the Declared tab, same with moving. This likely will need to be passed in via the url parameters so you can pull it down and see which tab you need to be on with ?tab=Declared or something like that.
bledsoef
requested changes
Apr 2, 2025
…StudentSoftwareDevTeam/celts into markInterestedAsDeclaredCCEMinor-1420
bledsoef
approved these changes
Apr 3, 2025
Contributor
bledsoef
left a comment
There was a problem hiding this comment.
Code and functionality is excellent!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
Previously, if a student expressed interest for minor, they will be recorded and showed on the minor page of the admin, with a table having the option to remove students. However, a new concept declared students begin as a student affirms and declared his intention to fulfill a minor. This new concept is not reflected in the old system.
Fixes #1420
Thus, the creation of a new status for Minor Candidates becomes necessary, with the two status being Interested and Declared. This innovation calls for changes from the databases and the backend all the way to the frontend.
Changes
declaredMinor- in theUsertable.Additional Fixes
Testing
test_minor.pyImages
1- BEFORE (MINOR MANAGEMENT PAGE)
2- AFTER (MINOR MANAGEMENT PAGE WITH FOCUS ON INTERESTED TAB)
3- AFTER (MINOR MANAGEMENT PAGE WITH FOCUS ON DECLARED TAB)
Enjoy !!!!