Centralized Program Manager Administration Implementation#1422
Centralized Program Manager Administration Implementation#1422bledsoef merged 33 commits intodevelopmentfrom
Conversation
…staff requirement for adding program managers. Need to fix strange bug with the Program Manager callback function.
…val of program managers. Need to ensure it works properly
…/BCStudentSoftwareDevTeam/celts into 1419-Prog-Manager-Implementation
…/BCStudentSoftwareDevTeam/celts into 1419-Prog-Manager-Implementation
bledsoef
left a comment
There was a problem hiding this comment.
Functionality is pretty good, there are a couple weird quirks though.
-
Did we make sure we updated the Student Staff permissions everywhere? Particularly on the User Profile. We can still only add a user on the user profile if they are a student staff which should no longer be the case.
-
You added a bunch of functionality to a route you never hit.
…Team/celts into 1419-Prog-Manager-Implementation
…/BCStudentSoftwareDevTeam/celts into 1419-Prog-Manager-Implementation
Appreciate the feedback. I was looking through the Student Staff page and in the process of changing it, Brian decided for us to leave it as is. The missing accordion on User Profile, CELTS Labor, that contains the alternative method for assigning Program Managers, contains additional information for Bonner Scholars and fetches Labor History. Brian decided for us to leave that particular page for only individuals with labor history in the system, as its visibility was fine as is. |
bledsoef
left a comment
There was a problem hiding this comment.
LGTM.
Changes I made:
- Changed the manager variable to programManager in app/logic/volunteers.py
- Adjusted the searchUser functionality to have a new option where it will search for all users instead of a particular kind.
Issue Description
Fixes #1419
Changes
Implemented new modal, routes and JavaScript functions for uploading/removing program managers using AJAX
Old look of Program Management page, Settings:

New look:

Program Management Modal:

Additionally, the logic for adding program managers was edited. For an incoming change, students will NO LONGER need to be Student Staff to gain the privileges of Program Manager. After a conversation with Brian, it appears that volunteers outside of Berea College are critical in certain programs; therefore, elevated privileges are in order. (See Enable Program Managers To Edit Program Details #1423 for further information)
Testing