Skip to content

Centralized Program Manager Administration Implementation#1422

Merged
bledsoef merged 33 commits intodevelopmentfrom
1419-Prog-Manager-Implementation
Mar 31, 2025
Merged

Centralized Program Manager Administration Implementation#1422
bledsoef merged 33 commits intodevelopmentfrom
1419-Prog-Manager-Implementation

Conversation

@ojmakinde
Copy link
Copy Markdown
Contributor

@ojmakinde ojmakinde commented Mar 5, 2025

Issue Description

Fixes #1419

  • In our app, there is no way to add or remove multiple program managers for any program in any centralized fashion. To add/remove a program manager, users have to first navigate to Student Search > Student Page Info > Add/Remove. For a bulk process, this can be quite tedious. A centralized approach would be a good implementation.

Changes

Implemented new modal, routes and JavaScript functions for uploading/removing program managers using AJAX

  • Old look of Program Management page, Settings:
    image

  • New look:
    image

  • Program Management Modal:
    image

  • Additionally, the logic for adding program managers was edited. For an incoming change, students will NO LONGER need to be Student Staff to gain the privileges of Program Manager. After a conversation with Brian, it appears that volunteers outside of Berea College are critical in certain programs; therefore, elevated privileges are in order. (See Enable Program Managers To Edit Program Details #1423 for further information)

image

Testing

  • Pull the branch and attempt to add/remove Program Managers by visiting Settings > Program Management.
  • All additions/removals should be successful.

@ojmakinde ojmakinde marked this pull request as ready for review March 5, 2025 15:28
Comment thread app/static/js/userManagement.js Outdated
Copy link
Copy Markdown
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is pretty good, there are a couple weird quirks though.

  1. Did we make sure we updated the Student Staff permissions everywhere? Particularly on the User Profile. We can still only add a user on the user profile if they are a student staff which should no longer be the case.

  2. You added a bunch of functionality to a route you never hit.

Comment thread tests/code/test_userManagement.py
Comment thread app/static/js/userProfile.js Outdated
Comment thread app/static/js/userManagement.js
Comment thread app/controllers/admin/userManagement.py Outdated
Comment thread app/controllers/admin/userManagement.py Outdated
Comment thread app/logic/volunteers.py Outdated
Comment thread app/templates/admin/userManagement.html
@ojmakinde
Copy link
Copy Markdown
Contributor Author

Functionality is pretty good, there are a couple weird quirks though.

1. Did we make sure we updated the Student Staff permissions everywhere? Particularly on the User Profile. We can still only add a user on the user profile if they are a student staff which should no longer be the case.

2. You added a bunch of functionality to a route you never hit.

Appreciate the feedback. I was looking through the Student Staff page and in the process of changing it, Brian decided for us to leave it as is. The missing accordion on User Profile, CELTS Labor, that contains the alternative method for assigning Program Managers, contains additional information for Bonner Scholars and fetches Labor History. Brian decided for us to leave that particular page for only individuals with labor history in the system, as its visibility was fine as is.

@github-actions
Copy link
Copy Markdown

View Code Coverage

Copy link
Copy Markdown
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Changes I made:

  • Changed the manager variable to programManager in app/logic/volunteers.py
  • Adjusted the searchUser functionality to have a new option where it will search for all users instead of a particular kind.

@bledsoef bledsoef merged commit 38e1067 into development Mar 31, 2025
5 checks passed
@bledsoef bledsoef deleted the 1419-Prog-Manager-Implementation branch March 31, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Program Manager selection to Program Edit Modal

4 participants