Skip to content

CCE Minor Withdrawal Functionality#1425

Merged
bledsoef merged 41 commits intodevelopmentfrom
1397_WithdrawalFunctionality
Apr 17, 2025
Merged

CCE Minor Withdrawal Functionality#1425
bledsoef merged 41 commits intodevelopmentfrom
1397_WithdrawalFunctionality

Conversation

@Kafui123
Copy link
Copy Markdown
Contributor

@Kafui123 Kafui123 commented Mar 11, 2025

Issue Description

Fixes #1397

  • Implemented the withdrawal functionality for the other experience and summer experience creations.

Changes

  • Added a withdrawal function in javascript that sends an ajax request to the withdrawProposal function in the routes.py file.
  • Created a new withdrawProposal function in the routes.py file to check to ensure that the information got deleted from both of the models.
  • Added a new removeProposal function in the minor.py file to delete the file and information stored in the CCEMinor and AttachmentUpload modals.
  • Created a test_removeProposal() function in the tests_minor.py file to see if all the information and files are deleted once the user selects the withdraw button for a specific experience. i.e summerExperience or otherExperience.

Testing

  • Checkout 1397_WithdrawFunctionality
  • Navigate to Minor Management in the Admin sidebar dropdown.
  • Click on the user ayisie to navigate to their CCE Minor Profile.
  • Switch to the Manage Proposals tab at the top.
  • Create an Other Engagement and a Summer Experience with random data.
  • Return to the Manage Proposals page and verify both of these proposals look something like this:
  • Click on the Select Action button and click on Withdraw
  • Check the attachment upload and cceminorproposal tables in the database to see if the information you entered has been deleted.

@Kafui123 Kafui123 changed the base branch from development to 1395_NewCCEMinorPortal March 11, 2025 21:12
@Kafui123 Kafui123 changed the base branch from 1395_NewCCEMinorPortal to 1411_OtherEngagementFiles March 11, 2025 21:13
@bledsoef bledsoef changed the title 1397 withdrawal functionality CCE Minor Proposal Withdrawal Mar 17, 2025
@bledsoef bledsoef changed the title CCE Minor Proposal Withdrawal CCE Minor Withdrawal Functionality Mar 17, 2025
Comment thread app/templates/minor/cceMinorProposalManagement.html
Comment thread app/templates/minor/cceMinorProposalManagement.html
Comment thread app/templates/minor/cceMinorProposalManagement.html
Comment thread app/templates/minor/cceMinorProposalManagement.html
Base automatically changed from 1411_OtherEngagementFiles to development April 8, 2025 19:14
@bledsoef
Copy link
Copy Markdown
Contributor

bledsoef commented Apr 8, 2025

Another enhancement idea: if somebody is on the Create Summer Experience or Create Engagement page, there is no way to cancel the process.

Done in a different PR

@bledsoef bledsoef requested a review from Copilot April 8, 2025 21:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 11 changed files in this pull request and generated 1 comment.

Files not reviewed (5)
  • app/templates/minor/cceMinorProposalManagement.html: Language not supported
  • app/templates/minor/companyOrganizationInformation.html: Language not supported
  • app/templates/minor/requestOtherEngagement.html: Language not supported
  • app/templates/minor/summerExperience.html: Language not supported
  • app/templates/minor/supervisorInformation.html: Language not supported
Comments suppressed due to low confidence (1)

app/logic/minor.py:368

  • The lookup field 'proposal' may be incorrect since tests refer to 'proposal_id'. Verify and use the correct field name to ensure proper retrieval of attachment records.
proposalAttachment = AttachmentUpload.get_or_none(proposal=proposalID)

Comment thread tests/code/test_minor.py Outdated
@bledsoef bledsoef dismissed stale reviews from MImran2002 and hoerstl April 14, 2025 22:20

Outdated

bledsoef
bledsoef previously approved these changes Apr 14, 2025
Copy link
Copy Markdown
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bledsoef bledsoef dismissed stale reviews from stevensonmichel and themself via c7580c1 April 17, 2025 19:45
@github-actions
Copy link
Copy Markdown

View Code Coverage

Copy link
Copy Markdown
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bledsoef bledsoef merged commit c3e689a into development Apr 17, 2025
5 checks passed
@bledsoef bledsoef deleted the 1397_WithdrawalFunctionality branch April 17, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add withdrawal functionality to Summer Experiences and Other Engagements

6 participants