-
Notifications
You must be signed in to change notification settings - Fork 14
v1.2.2 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hmmm, I replaced the sum approximation method used for the integral (to measure fbol) with a bootstrapping method @ECGonzales and I spoke about, but I get a VERY similar answer. I wonder if it's just correct given we are integrating a curve with SNR=100. This propagates down to a Teff ~ 2000 with an error of ~ Teff*0.01, or just a few tens of Kelvin, as we're seeing. Here's the old code: And here's the bootstrapping code: @ECGonzales what does your method look like that get's more realistic errors? |
|
So I just add the upper and lower limits to the photometry and create two text files with that data. I then run MakeSED on each and just take the difference between the upper and lower Lbols as the uncertainty. Lastly, I rerun the Teff function to get out better Teff uncertainties. I've attached some example code that I used for the Trappist paper. |
|
@ECGonzales ok, I see. I'm moving this discussion over to email! |
kelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just a couple comments about the Jy conversion.
| if u.equivalent(flux_units, q.Jy) and u.equivalent(self.flux_units, u.FLAM): | ||
|
|
||
| # Convert native FLAM units to Jy | ||
| self._flux = self._flux * self.wave ** 2 * 3.34e-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, is this converting to Jy? What are the numbers? Use astropy units instead?
| elif u.equivalent(self.flux_units, q.Jy) and u.equivalent(flux_units, u.FLAM): | ||
|
|
||
| # Convert native Jy units to FLAM | ||
| self._flux = self._flux * 3e18 / (self.wave ** 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use astropy units?
Improvements and bug fixes:
specutils.Spectrum1Dbokehimage save