Skip to content

Conversation

@DavidBlaa
Copy link
Member

No description provided.

paul-mars and others added 30 commits May 9, 2025 13:25
geofranzi and others added 28 commits November 21, 2025 23:42
EntityName
Bringing back previous working code to retrieve citations via api
}

private getReadableComment(): string {
return this.comment.replace(/\\/, '');

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding

This replaces only the first occurrence of /\\/.

Copilot Autofix

AI about 1 month ago

To fully address the escaping/encoding issue, we need to ensure that the replace call in getReadableComment() removes all backslashes, not just the first. This is done by adding the g (global) flag to the regular expression. No other files or regions need to be changed. No new imports or helper methods are required—just replace /\\/ with /\\/g on line 62. This minimizes side effects while ensuring all unwanted characters are stripped.


Suggested changeset 1
Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/lib/models/CurationNote.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/lib/models/CurationNote.ts b/Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/lib/models/CurationNote.ts
--- a/Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/lib/models/CurationNote.ts
+++ b/Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/lib/models/CurationNote.ts
@@ -59,7 +59,7 @@
 	}
 
 	private getReadableComment(): string {
-		return this.comment.replace(/\\/, '');
+		return this.comment.replace(/\\/g, '');
 	}
 
 	private getCommandType(): CurationNoteCommandType {
EOF
@@ -59,7 +59,7 @@
}

private getReadableComment(): string {
return this.comment.replace(/\\/, '');
return this.comment.replace(/\\/g, '');
}

private getCommandType(): CurationNoteCommandType {
Copilot is powered by AI and may make mistakes. Always verify output.
@DavidBlaa DavidBlaa merged commit eebd73f into master Nov 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants