-
Notifications
You must be signed in to change notification settings - Fork 15
release 4.2.0 #2287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 4.2.0 #2287
Conversation
… lower L) to userIsDone in frontend
Bringing back previous working code to retrieve citations via api
| } | ||
|
|
||
| private getReadableComment(): string { | ||
| return this.comment.replace(/\\/, ''); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To fully address the escaping/encoding issue, we need to ensure that the replace call in getReadableComment() removes all backslashes, not just the first. This is done by adding the g (global) flag to the regular expression. No other files or regions need to be changed. No new imports or helper methods are required—just replace /\\/ with /\\/g on line 62. This minimizes side effects while ensuring all unwanted characters are stripped.
-
Copy modified line R62
| @@ -59,7 +59,7 @@ | ||
| } | ||
|
|
||
| private getReadableComment(): string { | ||
| return this.comment.replace(/\\/, ''); | ||
| return this.comment.replace(/\\/g, ''); | ||
| } | ||
|
|
||
| private getCommandType(): CurationNoteCommandType { |
No description provided.