Add file locking to prevent race conditions on cl.json #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces a file_lock() context manager using fcntl to ensure exclusive access to cl.json during read/write operations. It prevents race conditions when multiple git cl add/remove/delete processes run concurrently. Lock file is created as cl.lock alongside cl.json Locking is applied in clutil_load() and clutil_save() Encoding explicitly set to utf-8 to satisfy pylint W1514 This change improves robustness in multi-process environments on Unix-like systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a clutil_file_lock() context manager using fcntl to ensure exclusive access to the cl.json changelist file. It addresses race conditions that could occur when multiple git cl add/remove/delete processes run concurrently.
Changes:
Impact: