Skip to content

Add publish_container.py#309

Merged
EZoni merged 6 commits intomainfrom
topic-publish-ml-script
Oct 30, 2025
Merged

Add publish_container.py#309
EZoni merged 6 commits intomainfrom
topic-publish-ml-script

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Oct 20, 2025

Generalize our container build and publish script to also build the ML container #302.

@ax3l ax3l requested a review from EZoni October 20, 2025 15:50
@ax3l ax3l added the ml Changes related to the ML models label Oct 20, 2025
This was referenced Oct 20, 2025
@EZoni
Copy link
Member

EZoni commented Oct 20, 2025

How much of this code is similar to the one in publish_dashboard.py?

I would be in favor of reusing as much as code as possible and avoid duplication as much as possible.

Here's the diff:

0a1,5
> #!/usr/bin/env python
> """
> Build the ML training container (with CUDA support) for
> Perlmutter (NERSC) and publish it to registry.nersc.gov
> """
28c33
<     command = "docker build --platform linux/amd64 -t gui -f dashboard/Dockerfile ."
---
>     command = "docker build --platform linux/amd64 -t gui -f ml/Dockerfile ."
35,37c40,42
<         "docker tag gui:latest registry.nersc.gov/m558/superfacility/gui:latest",
<         "docker tag gui:latest registry.nersc.gov/m558/superfacility/gui:$(date '+%y.%m')",
<         "docker push -a registry.nersc.gov/m558/superfacility/gui",
---
>         "docker tag gui:latest registry.nersc.gov/m558/superfacility/ml-training:latest",
>         "docker tag gui:latest registry.nersc.gov/m558/superfacility/ml-training:$(date '+%y.%m')",
>         "docker push -a registry.nersc.gov/m558/superfacility/ml-training",

@EZoni
Copy link
Member

EZoni commented Oct 20, 2025

If it comes down to basically replacing dashboard with ml and gui with ml-training, I would try to make one single script with a command line option to decide which container image to publish, e.g.,

python publish_container.py --dashboard
python publish_container.py --ml-training

or, maybe more concise,

python publish_container.py --gui
python publish_container.py --ml

If you want, I could push some changes to this PR to implement this - let me know.

@ax3l
Copy link
Member Author

ax3l commented Oct 20, 2025

How much of this code is similar to the one in publish_dashboard.py?

95% :D

@ax3l
Copy link
Member Author

ax3l commented Oct 20, 2025

If you want, I could push some changes to this PR to implement this - let me know.

Ok sounds good. I can do it real quick.

@ax3l ax3l force-pushed the topic-publish-ml-script branch from 4bd432b to fbddd50 Compare October 20, 2025 21:36
@ax3l ax3l force-pushed the topic-publish-ml-script branch 7 times, most recently from 85a3e7d to c50adb8 Compare October 20, 2025 21:59
ax3l added 3 commits October 22, 2025 16:51
Add a script to build and publish the ML
container.
@ax3l ax3l force-pushed the topic-publish-ml-script branch from c50adb8 to d5073e8 Compare October 22, 2025 23:52
@RemiLehe RemiLehe assigned EZoni and unassigned RemiLehe Oct 23, 2025
@RemiLehe RemiLehe requested review from EZoni and RemiLehe and removed request for EZoni and RemiLehe October 23, 2025 17:38
@ax3l ax3l changed the title Add publish_ml.py Add publish_container.py Oct 30, 2025
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
@ax3l ax3l requested a review from EZoni October 30, 2025 17:31
@EZoni EZoni merged commit ff88a29 into main Oct 30, 2025
@EZoni EZoni deleted the topic-publish-ml-script branch October 30, 2025 18:10
ax3l added a commit that referenced this pull request Nov 26, 2025
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ml Changes related to the ML models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants