Skip to content

Trash vatom#11

Merged
jackmcintosh merged 3 commits intodevfrom
trash-vatom
Jul 10, 2018
Merged

Trash vatom#11
jackmcintosh merged 3 commits intodevfrom
trash-vatom

Conversation

@jackmcintosh
Copy link
Copy Markdown
Contributor

No description provided.

@jackmcintosh jackmcintosh requested review from cjmconie and jjv360 July 10, 2018 07:33
Comment thread src/client/manager/Vatoms.js Outdated
/**
* Deletes a vatom from your inventory
* @param {String} vatomID Id of the vAtom you want to delete
* Removes a vatom from your inventory
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer: "Removes the specified vAtom from the current user's inventory."

The audience is the developer, and the developer is writing the app for the public. So avoid pronouns like "your", rather refer to "the current user".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in commit
8f8e9e7

Copy link
Copy Markdown

@cjmconie cjmconie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor language change required.

@jackmcintosh jackmcintosh merged commit b9d7d57 into dev Jul 10, 2018
@jackmcintosh jackmcintosh deleted the trash-vatom branch November 12, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants