Skip to content

POLIO-1958: add exclusion list for prep worksheets#2526

Merged
quang-le merged 3 commits intodevelopfrom
fix/POLIO-1958_hard_code_common_exclusions_in_preparedness
Oct 31, 2025
Merged

POLIO-1958: add exclusion list for prep worksheets#2526
quang-le merged 3 commits intodevelopfrom
fix/POLIO-1958_hard_code_common_exclusions_in_preparedness

Conversation

@quang-le
Copy link
Copy Markdown
Member

@quang-le quang-le commented Oct 30, 2025

Client adds worksheets to the preparedness google sheet, and it breaks everyting

Related JIRA tickets : POLIO-1958

Self proofreading checklist

  • Did I use eslint and ruff formatters?
  • Is my code clear enough and well documented?
  • Are my typescript files well typed?
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests?
  • Documentation has been included (for new feature)

Doc

Tell us where the doc can be found (docs folder, wiki, in the code...).

Changes

  • Hard coded an exclusion on common sheet names
  • Added a config for additional exclusions
  • Fixed small bug with round number in the preparedness parser

How to test

  • Generate a preparedness sheet (needs a round with a scope and a future start date)
  • Add empty worksheets to the generated sheets
  • rename at least 1.
  • Add the custom worksheet name to the preparedness_sheetnames_blacklistconfig (add it if necessary: it just a list of strings). In the new sheet, add (in any cell) the string: "Summary of Regional Level Preparedness"(this will circumvent the exclusion mechanism already in place)
  • From the preparedness tab, launch a refresh: the additional sheets should not trigger errors

Note

This should go in the next release one way or another since it would solve refresh problems with an actual upcoming campaign

@quang-le quang-le added the release Should be released in production at next deploy label Oct 30, 2025
Copy link
Copy Markdown
Member

@tdethier tdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine after applying the suggested change 👍

@quang-le quang-le merged commit c9e9617 into develop Oct 31, 2025
7 checks passed
@quang-le quang-le deleted the fix/POLIO-1958_hard_code_common_exclusions_in_preparedness branch October 31, 2025 11:01
quang-le added a commit that referenced this pull request Oct 31, 2025
refs: POLIO-1958

* POLIO-1958: add exclusion list for prep worksheets

* Update plugins/polio/preparedness/parser.py

* POLIO-1958: improve exclusions parsing

---------

Co-authored-by: Thibault Dethier <84660492+tdethier@users.noreply.github.com>
@Bewi Bewi added user tested Has already been tested on staging ok for release Released and removed ok for release labels Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Should be released in production at next deploy Released user tested Has already been tested on staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants