Conversation
This commit adds a step to all jobs across the `build.yml`, `code-quality.yml`, and `production-release.yml` workflows to dynamically create the `local.properties` file. This ensures that the Android SDK location is correctly configured by writing `sdk.dir=$ANDROID_HOME` before any Gradle tasks are executed, preventing potential build failures related to SDK path resolution.
There was a problem hiding this comment.
Pull request overview
This PR adds a step to create the local.properties file in all GitHub Actions workflow jobs before executing Gradle tasks. This ensures the Android SDK path is properly configured via sdk.dir=$ANDROID_HOME, preventing potential build failures due to SDK path resolution issues.
Changes:
- Added
Create local.propertiesstep to all 7 jobs across 3 workflow files - Step is consistently placed after granting gradlew execute permissions and before any Gradle task execution
- Uses ANDROID_HOME environment variable which is pre-configured in GitHub Actions ubuntu-latest runners
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/build.yml | Added local.properties creation to 3 jobs (build, lint, test) |
| .github/workflows/code-quality.yml | Added local.properties creation to 2 jobs (code-quality, dependency-check) |
| .github/workflows/production-release.yml | Added local.properties creation to 2 jobs (production-build, quality-gate) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a step to all jobs across the
build.yml,code-quality.yml, andproduction-release.ymlworkflows to dynamically create thelocal.propertiesfile.This ensures that the Android SDK location is correctly configured by writing
sdk.dir=$ANDROID_HOMEbefore any Gradle tasks are executed, preventing potential build failures related to SDK path resolution.