Use add_definitions instead of set(CMAKE_CXX_FLAGS) to fix Windows build#14
Merged
cen1 merged 1 commit intoBNETDocs:masterfrom Jul 1, 2018
nielsAD:cmake
Merged
Use add_definitions instead of set(CMAKE_CXX_FLAGS) to fix Windows build#14cen1 merged 1 commit intoBNETDocs:masterfrom nielsAD:cmake
cen1 merged 1 commit intoBNETDocs:masterfrom
nielsAD:cmake
Conversation
Other changes: * Fix indentation in CMakeLists.txt (tabs to spaces) * Fix CMake builds outside of project directory
Contributor
|
Looks good to me. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was experiencing linking errors on Windows when building with MSYS2 x64. Using
add_definitionsinstead ofset(CMAKE_CXX_FLAGS)fixes this. I took the liberty to fix the following issues as well:CMAKE_MODULE_PATHrelative toPROJECT_SOURCE_DIRto fix builds outside of project directory