build: common CMakeLists to rule them all#6
Merged
Merged
Conversation
ggalgoczi
added a commit
that referenced
this pull request
May 1, 2026
…Photon genstep MakeGenstep_QuasiCerenkov / MakeGenstep_QuasiScintillation were reading pos/time from token->GetPosition() / GetGlobalTime(). By the time UserSteppingAction fires, those reflect the POST-step of the token's first step, not its birth position. Read birth values from aStep->GetPreStepPoint() instead — that matches the parent's pre-step (x0, t0) where G4QuasiCerenkov::PostStepDoIt constructs the secondary (see G4QuasiCerenkov.cc:273, `new G4Track(quasiPhoton, t0, x0)`). Validated against the cascade route on Cerenkov-only geometry (opticks_raindrop.gdml, no scintillation properties — bypasses upstream G4 bug #6 in G4QuasiScintillation::PostStepDoIt) at fixed seed 42: mode route Opticks NumHits G4 NumHits serial cascade 13411 0 serial photon 13438 0 (cascade route ± 0.2%) event-mt cascade 12124 0 event-mt photon 12123 0 (off by 1 hit at fixed seed) subevt cascade 12124 0 subevt photon 0 0 (still bug #7: aux marshalling) Photon-route correctness in serial / event-MT now established. Sub-event mode remains broken due to G4 11.4.1 sub-event marshalling not preserving G4VAuxiliaryTrackInformation across the master->worker handoff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes the entire package (the min useful sub-packages) can be built as: