Skip to content

Implement unregistering events#10

Merged
BOLL7708 merged 1 commit intoBOLL7708:pullrequest/unregister-eventsfrom
Antoni-Czaplicki:master
Jul 23, 2024
Merged

Implement unregistering events#10
BOLL7708 merged 1 commit intoBOLL7708:pullrequest/unregister-eventsfrom
Antoni-Czaplicki:master

Conversation

@Antoni-Czaplicki
Copy link
Copy Markdown
Contributor

Implement unregistering events and add missing System import

@BOLL7708 BOLL7708 changed the base branch from master to pullrequest/unregister-events July 23, 2024 08:07
@BOLL7708 BOLL7708 merged commit 6ae136d into BOLL7708:pullrequest/unregister-events Jul 23, 2024
@BOLL7708
Copy link
Copy Markdown
Owner

BOLL7708 commented Jul 23, 2024

I just merged this into a separate branch to test things out, as I was curious about the system imports. My IDE, Rider, reports them as unnecessary and wants to remove them again, but I guess your IDE complained about them not being included, @Antoni-Czaplicki ?

Edit: Now I'm thinking that maybe it is due to the project I'm editing this submodule in, maybe the parent class already has those imports and as such it deems them unnecessary in the class library.

Edit2: Alright, I did not have them in as the project settings include <ImplicitUsings>enable</ImplicitUsings> which uses System by default without it being included. Is this something that is not working in your project(s)? I can turn it off for compatibility but I'm interested.

@BOLL7708
Copy link
Copy Markdown
Owner

And I ended up just turning off implicit usings, now merged into master 😁

@Antoni-Czaplicki
Copy link
Copy Markdown
Contributor Author

Hmm, I’m also using Rider and I’ve added this imports because the project wouldn’t compile without them. I just checked and I don’t have <ImplicitUsings>enable</ImplicitUsings>, so it’s probably the reason why it occurred. Anyway I think it’s better to leave this imports in files to make ot work on both type of projects

@BOLL7708
Copy link
Copy Markdown
Owner

BOLL7708 commented Oct 4, 2025

Hello dear contributor!

I have re-licensed this project as GPLv3, and I have plans to combine my various VR applications into a single toolkit and publish that freely on Steam. That requires the project to be licensed to me using LGPLv3 as well, as Steam does not allow the full GPLv3 license, so I've added a new Contributor License Agreement to this project to facilitate this.

I hope you are willing to sign this agreement to accept the new licensing changes. You can do this by editing the CLA.md file directly here on GitHub and submit it as a pull request. Any contribution that does not get re-licensed will be eventually be removed from the project. If you have any questions, don't hesitate to reply to me here.

Thank you for your consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants