Credentials fix #74
Merged
Credentials fix #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looselycoupled
approved these changes
Aug 12, 2020
| CONFIG_DIR = ".predictivegrid" | ||
| CREDENTIALS_FILENAME = "credentials.yaml" | ||
| CREDENTIALS_PATH = os.path.join(os.environ["HOME"], CONFIG_DIR, CREDENTIALS_FILENAME) | ||
| CREDENTIALS_PATH = os.path.join(os.path.expanduser("~"), CONFIG_DIR, CREDENTIALS_FILENAME) |
Member
There was a problem hiding this comment.
It looks like your solution will work for the problem of no HOME env var. But what happens if they are using an account with no user directory at all?
Member
There was a problem hiding this comment.
I just created a user with no home directory and it just gives back the root directory. If the credentials file doesnt exist, the code will just gracefully ignore this.
Member
|
@looselycoupled can you release this on pypi? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the solution in this SO post: https://stackoverflow.com/questions/4028904/how-to-get-the-home-directory-in-python
Should work with all operating systems now