Skip to content

Credentials fix #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Credentials fix #74

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0316087
updating grpcio dependency
mchestnut91 Jun 29, 2020
f0024f7
Merge branch 'develop' of https://github.com/BTrDB/btrdb-python into …
mchestnut91 Jul 23, 2020
bcc28a5
fixes credential path bug
mchestnut91 Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion btrdb/utils/credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

CONFIG_DIR = ".predictivegrid"
CREDENTIALS_FILENAME = "credentials.yaml"
CREDENTIALS_PATH = os.path.join(os.environ["HOME"], CONFIG_DIR, CREDENTIALS_FILENAME)
CREDENTIALS_PATH = os.path.join(os.path.expanduser("~"), CONFIG_DIR, CREDENTIALS_FILENAME)
Copy link
Member

@looselycoupled looselycoupled Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like your solution will work for the problem of no HOME env var. But what happens if they are using an account with no user directory at all?

Copy link
Member

@looselycoupled looselycoupled Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created a user with no home directory and it just gives back the root directory. If the credentials file doesnt exist, the code will just gracefully ignore this.


##########################################################################
## Functions
Expand Down