Replace uses of POSIX open/close#3444
Open
eelstork wants to merge 1 commit intoBVLC:masterfrom
BonsaiAI:avoid-posix-io
Open
Replace uses of POSIX open/close#3444eelstork wants to merge 1 commit intoBVLC:masterfrom BonsaiAI:avoid-posix-io
eelstork wants to merge 1 commit intoBVLC:masterfrom
BonsaiAI:avoid-posix-io
Conversation
Contributor
|
Contributor
Author
|
@ajtulloch a performance dip is expected according to Although I agree that error handling should be customisable, the current implementation falls short. For sake, have a look at Raising standard or custom i/o exceptions may be appropriate. |
Contributor
|
+1 for this as it will help many of us maintaining Windows forks of Caffe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protobuf related i/o in Caffe relies on POSIX
open/close. These functions are not cross-platform.If performance concerns are not critical, the proposed solution (kindly suggested by @willyd and @keenbrowne) may be adequate.
Previously,
ReadXXX/ReadXXXOrDie,WriteXXX/WriteXXXOrDievariants were available; fail-slow variants had no uses in higher level APIs, possibly unsafe uses in tests and examples.