Little enhancement to the plot_training_log.py.example -- non-blocking execution#6438
Open
onkarganjewar wants to merge 1 commit intoBVLC:masterfrom
Open
Little enhancement to the plot_training_log.py.example -- non-blocking execution#6438onkarganjewar wants to merge 1 commit intoBVLC:masterfrom
onkarganjewar wants to merge 1 commit intoBVLC:masterfrom
Conversation
Do not block the plot_training_log.py.example script so that it can run to completion. If user chooses not to exit the plot preview window or did not see the preview window at all, then the script might keep on running instead of terminating in the end.
onkarganjewar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
caffe/tools/extra/plot_training_log.py.examplethere is a call toplt.show().plt.show()does not open up an image preview for the user to close unless the interactive mode is on withplt.pause().What does this PR do?
a. Add the
(block=False)to override the blocking behavior. Or,b. Make the plot interactive using
plt.ion()and add certainpause()for the user to react to the plot frame within a certain limit, so the script won't keep on running forever.Why is it necessary?
I know that plot_training_log.py.example is supposed to be an example and customization is a must.
But, I still believe including/introducing this non-blocking execution approach to the end user would be beneficial and could save some time investigating this problem, especially on the OS X machines.
System configuration
Operating system: mac OS X Sierra 10.12.6
BLAS: open
Python version (if using pycaffe): Python 2.7.15 :: Anaconda, Inc.