refactor: remove gateway observer hooks and dead recorder exports#130
Merged
refactor: remove gateway observer hooks and dead recorder exports#130
Conversation
Observer hooks logged [verify] diagnostics but never compared against gateway decisions — pure write-only scaffolding. Gateway mode now runs the full plugin hooks with provider baseURL rewriting in the config hook. Also removes unused loadFixtures() and isRecording() from recorder.ts. Replay interceptor and test infrastructure remain intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[verify]diagnostics for gradient/LTM but never compared against the gateway's actual decisions (write-only scaffolding)hooks.config— gateway mode now runs the full plugin hooks, only difference is baseURL rewritingrecorder.ts:loadFixtures()andisRecording()(never called anywhere; replay interceptor and test infrastructure remain intact)744 tests pass, all packages typecheck clean.