fix(db): use os.homedir() for cross-platform data directory resolution#131
Merged
fix(db): use os.homedir() for cross-platform data directory resolution#131
Conversation
#121) On Windows, process.env.HOME is not set (Windows uses USERPROFILE), so the fallback literal "~" was passed to path.join() which does not perform shell tilde expansion. This created the database at C:\Users\<user>\~\.local\share\opencode-lore instead of the correct C:\Users\<user>\.local\share\opencode-lore. Replace process.env.HOME || "~" with os.homedir() which correctly resolves the home directory on all platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #121
process.env.HOME || "~"withos.homedir()indataDir()to correctly resolve the home directory on Windows, whereHOMEis not set (Windows usesUSERPROFILE)C:\Users\<user>\~\.local\share\opencode-loreinstead ofC:\Users\<user>\.local\share\opencode-loreDetails
Node's
path.join()does not perform shell tilde expansion, so passing the literal string"~"as a fallback produces a broken path.os.homedir()is the correct cross-platform API — it checksUSERPROFILEon Windows andHOMEon Unix.The
input.summaries.lengtherror reported in the issue could not be reproduced or traced to a specific init-time code path. It may be a secondary effect of the wrong DB path or a Bun-on-Windows module resolution issue. If it persists after this fix, a stack trace would be needed.