fix: deduplicate concurrent models.dev fetch requests#282
Merged
Conversation
fetchModelData() cached the resolved result but not the in-flight promise, so concurrent calls before the first resolved each fired a separate HTTP request. Store the pending promise in a module-level variable and return it for subsequent callers until settlement.
BYK
force-pushed
the
fix/memoize-models-dev-fetch
branch
from
081b367 to
4b53716
Compare
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchModelData()cached the resolved result (TTL-based) but not the in-flight promise, so concurrent calls before the first resolved each fired a separate HTTP request tomodels.dev/api.jsoninflightFetchmodule-level variable — concurrent callers now share a single in-flight requestmodels.dev: loaded data for 75 models across anthropic, openairepeated 6 times at the same timestamp