fix: strip recall marker text from temporal storage to prevent FTS echo#306
Merged
Conversation
Recall markers (📚 Searching ... for "<query>"…) were stored as regular text in temporal_messages, causing FTS5 to index the raw query string. Future searches for the same terms would surface the marker as a top result — pure noise that wastes result slots and creates self-reinforcing echo in search results. Filter out recall marker text blocks before passing assistant content to temporal.store(). Markers are still sent to the client and used for round-trip expansion — only the FTS index is kept clean.
Single source of truth for marker format detection — isRecallMarker now delegates to parseRecallMarker instead of duplicating regex checks. Added unit tests covering search markers, id-based detail markers, and non-marker rejection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
📚 Searching ... for "<query>"…) were stored as regular text parts intemporal_messages, causing FTS5 to index the raw query string. Future searches for the same terms surfaced the marker as a top result — pure noise that wastes result slots and creates a self-reinforcing echo effect.isRecallMarker()predicate inrecall.tsand filter inpostResponse()(pipeline.ts) to strip marker text blocks beforetemporal.store(). Markers are still sent to the client and used for round-trip expansion — only the FTS index is kept clean.Changes
packages/gateway/src/recall.tsisRecallMarker()using existing marker regexespackages/gateway/src/pipeline.ts