Skip to content

fix: show craft stderr on nightly version failure for debugging #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
May 14, 2026
Merged

fix: show craft stderr on nightly version failure for debugging #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ jobs:

# 2. Get bump type from craft (analyzes conventional commits since last tag)
BUMP_TYPE="patch" # conservative fallback
if CRAFT_JSON=$(craft changelog --format json 2>/dev/null); then
CRAFT_ERR=$(mktemp)
if CRAFT_JSON=$(craft changelog --format json 2>"$CRAFT_ERR"); then
DETECTED=$(echo "$CRAFT_JSON" | jq -r '.bumpType // empty')
if [ -n "$DETECTED" ]; then
BUMP_TYPE="$DETECTED"
Expand All @@ -93,7 +94,9 @@ jobs:
fi
else
echo "::warning::craft changelog failed, falling back to bump type: ${BUMP_TYPE}"
cat "$CRAFT_ERR"
fi
rm -f "$CRAFT_ERR"

# 3. Get current version from package.json
CURRENT=$(jq -r .version packages/gateway/package.json)
Expand Down
Loading