fix: use export for env vars in install script examples#319
Merged
Conversation
LORE_VERSION=nightly curl ... | bash sets the variable in curl's environment, not in the bash process that runs the script. The pipe creates a separate process that never inherits it, so the variable resolves to empty and the script falls through to latest release. Fix by using export so the variable is visible to all child processes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LORE_VERSION=nightly curl ... | bashsets the variable incurl's environment, not in thebashprocess that runs the piped script — soLORE_VERSIONalways resolves to emptyexport LORE_VERSION=nightly && curl ... | bashwhich correctly propagates the variable through the pipeLORE_INSTALL_DIRexample (same bug)