fix: resolve pi build rootDir error by adding types export to core#346
Merged
Conversation
The pi package's tsconfig.build.json had a paths mapping that resolved @loreai/core to source files, pulling them outside rootDir during declaration emission. Remove the paths mapping and add a 'types' export condition to core's package.json so tsc resolves to pre-built .d.ts files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the release build failure for v0.20.0 (CI run #813).
pathsmapping frompackages/pi/tsconfig.build.jsonthat caused tsc to follow into core's source files during declaration emission, violatingrootDir"types"export condition topackages/core/package.jsonso tsc resolves@loreai/coreto pre-built.d.tsfiles instead of sourceThe root cause was introduced in #331 which added a static
import { getGitRemote } from "@loreai/core"to pi'sindex.ts. Thepathsmapping made tsc resolve this to../core/src/index.ts(the barrel file), pulling all of core's source into the compilation — all outside pi'srootDir: "src". This only fails duringtsc -p tsconfig.build.json(declaration emission), not duringtsc --noEmit(typecheck).