feat: persist table sort order to localStorage#354
Merged
Conversation
Add localStorage persistence for sort column + direction across all
sortable tables in the web dashboard. On page load, saved sort is
restored; if no saved state exists, tables with a date/recency column
default to most-recent-first (descending).
- Add data-table-id to all 8 sortable tables for unique identification
- Add data-default-sort="desc" to 6 recency date columns
- Extract sortTable() function that persists {col, dir} to localStorage
- Restore saved sort on DOMContentLoaded with fallback to defaults
- Graceful degradation when localStorage is unavailable
Restrict saved dir to 'asc'|'desc' to prevent classList.add() from throwing on corrupted/tampered localStorage values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localStoragefor all 8 sortable tables in the web dashboardlocalStorageis unavailable (private browsing, quota errors)Details
Single file change:
packages/gateway/src/ui.tsdata-table-idto all 8 sortable tables (6 inline + 2 viarenderLiveSessionsTableparameter)data-default-sort="desc"to 6 recency date columns (Created, Updated, Last Activity, Last Active)sortTable(th, dir)that persists{col, dir}tolocalStorageunderlore-sort:{tableId}, plus restore-on-load logic that checks localStorage first, falls back todata-default-sortlocalStorage key format:
lore-sort:{tableId}→{"col": 0, "dir": "desc"}