fix: add amnesia mode and x-lore-no-store to prevent QA contamination in recall#430
Merged
Conversation
…mination in recall Adds two mechanisms to suppress temporal storage and background work: 1. /lore:amnesia:on|off slash command — session-scoped toggle for users 2. x-lore-no-store header — per-request flag for programmatic use (eval) Also generalizes /lore:* slash command handling: - New handleLoreSlashCommand() dispatcher catches ALL /lore:* commands - Unknown commands get a helpful error instead of being forwarded upstream - Shared slashResponse() helper for consistent response format The eval harness uses x-lore-no-store on QA questions to prevent QA session responses from contaminating recall search results.
BYK
added a commit
that referenced
this pull request
May 21, 2026
…indow (#435) Updates marketing copy with the latest eval results from the recall quality + distillation transparency work (#428, #430, #431, #432, #433, #434). ### README.md - Context retention table: Medium 2.3→4.1, Hard 3.3→4.8, Average 3.9→4.6 - Lore vs tail-window delta: +50%→+77% - Added footnote: Lore scores averaged across multiple runs; TW/compaction baselines from a prior eval run with the same scenarios - Added v6 to version history ### docs/index.html - Hero stat: +50%→+77% vs tail-window - Detail retention: 4.8→4.6 (overall average across difficulty levels, multiple runs) ### Review corrections - Fixed Medium from 4.3→4.1 (honest multi-run average, not cherry-picked) - Average row (4.6) now self-consistent with column values: (5.0+4.1+4.8)/3=4.63≈4.6 - Added footnote clarifying that TW/compaction columns are from a prior eval run
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two mechanisms to suppress temporal storage and background work without affecting Lore's read path (LTM injection, recall tool, gradient transform):
/lore:amnesia:on|off— session-scoped toggle via slash commandx-lore-no-store— per-request header for programmatic useAlso generalizes
/lore:*slash command handling so unknown commands get a helpful error instead of being forwarded upstream.Problem
The eval's QA questions were sent through the gateway as new sessions, creating temporal messages and distillations that contaminated recall search results. When QA question N+1 invoked recall, it found QA session N's responses (which literally contained the question terms) instead of the actual replay session content.
Changes
Gateway (
pipeline.ts)handleLoreSlashCommand(): Generic dispatcher for all/lore:*commands — routes to warm/curate/amnesia handlers, returns error for unknown commandshandleAmnesiaSlashCommand(): TogglessessionState.amnesiaflagpostResponse(): Gates temporal storage and background work on!noStorewherenoStore = sessionState.amnesia || req.rawHeaders['x-lore-no-store'] === 'true'slashResponse()helperTypes (
translate/types.ts)amnesia?: booleantoSessionStateEval (
harness.ts)x-lore-no-store: trueheaderVerification