Skip to content

fix(ci): write Craft publish-state file so retries skip already-published targets#449

Merged
BYK merged 1 commit into
mainfrom
fix/publish-state-file
May 21, 2026
Merged

fix(ci): write Craft publish-state file so retries skip already-published targets#449
BYK merged 1 commit into
mainfrom
fix/publish-state-file

Conversation

@BYK
Copy link
Copy Markdown
Owner

@BYK BYK commented May 21, 2026

The Publish workflow was missing the equivalent of getsentry/publish's "Set targets" step. When a publish partially fails (e.g. npm returns E401 after actually publishing), retrying would fail with "cannot publish over previously published versions" because Craft didn't know which targets already succeeded.

This adds:

  1. Set already-published targets step: parses checked targets from the publish issue body and writes a Craft publish-state file so Craft skips them
  2. Update published targets in issue step: on failure/cancel, reads Craft's state file and checks off successfully published targets in the issue body for the next retry

Modelled after getsentry/publish's workflow.

@BYK BYK enabled auto-merge (squash) May 21, 2026 11:05
@BYK BYK merged commit 4baf67f into main May 21, 2026
7 checks passed
@BYK BYK deleted the fix/publish-state-file branch May 21, 2026 11:06
@craft-deployer craft-deployer Bot mentioned this pull request May 21, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant