fix: prevent EROFS crash when launched outside a git repo#44
Merged
Conversation
When OpenCode launches outside a git repo, projectPath resolves to '/'
and AGENTS.md file operations attempt to write to the filesystem root
(e.g. mkdirSync('//') on macOS → EROFS).
Changes:
- Add isValidProjectPath() guard that rejects '/', '', and falsy paths
- Replace template literal path construction with path.join()
- Guard both AGENTS.md import and export blocks with the path check
- Add unit tests for isValidProjectPath and plugin init with '/' path
Fixes #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25
Problem
When OpenCode is launched from a directory that is not a git repository (e.g. the user's home directory), the lore plugin crashes with an
EROFS: read-only file systemerror trying to write to//AGENTS.md.The root cause:
projectPathresolves to/when there is no git worktree andctx.directoryis the filesystem root. The template literal${projectPath}/${cfg.agentsFile.path}then produces//AGENTS.md, andmkdirSync(dirname("//AGENTS.md"))attempts to write to the system root — which is read-only on macOS (EROFS).Fix
Add
isValidProjectPath()guard — returnsfalsefor root (/), empty, or falsy paths. Guards both the import (startup) and export (session.idle) code paths to prevent any filesystem operations on invalid project paths.Use
path.join()instead of template literal concatenation — replaces\${projectPath}/${path}`withjoin(projectPath, path)` for proper path construction. This is a defense-in-depth measure that normalizes paths correctly.Changes
src/index.ts: AddedisValidProjectPath()export, guarded both agents-file blocks, switched tojoin()test/index.test.ts: Added unit tests forisValidProjectPathand integration test verifying plugin initializes without crashing whenprojectPathis/