fix: auto-enable embeddings when VOYAGE_API_KEY is set#51
Merged
Conversation
- Flip search.embeddings.enabled default from false to true - isAvailable() now returns true when VOYAGE_API_KEY is set, unless explicitly disabled via enabled: false in .lore.json - Remove redundant config().search.embeddings.enabled check from startup backfill — isAvailable() already handles it - Users just need to set VOYAGE_API_KEY, no config change needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the need to manually set
search.embeddings.enabled: truein.lore.json. IfVOYAGE_API_KEYis present in the environment, embeddings are automatically active.To explicitly disable embeddings even with the key set:
{ "search": { "embeddings": { "enabled": false } } }