fix: sanitize unpaired Unicode surrogates in recall and temporal storage#68
Merged
fix: sanitize unpaired Unicode surrogates in recall and temporal storage#68
Conversation
…all output
Tool outputs (bash, grep, read) can contain unpaired surrogates from binary
file content. These survive into the DB and break JSON serialization when
included in recall tool responses ('no low surrogate in string').
Fix: sanitize at ingestion (partsToText) and output (inline) using a regex
that replaces unpaired surrogates with U+FFFD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
The request body is not valid JSON: no low surrogate in stringerror when using the recall tool.partsToText()into the temporal_messages DB, and when the recall tool includes them in its response, JSON serialization for the LLM API fails.sanitizeSurrogates()insrc/markdown.tsreplaces unpaired surrogates (high without low, lone low) with U+FFFD. Applied at two layers:partsToText()insrc/temporal.ts— prevents bad data from entering the DBinline()insrc/markdown.ts— sanitizes any pre-existing bad data when formatting recall results