feat: Publish docker#166
Merged
AverageHelper merged 20 commits intomainfrom Oct 3, 2024
Merged
Conversation
JstnMcBrd
reviewed
Aug 24, 2024
Merged
JstnMcBrd
reviewed
Aug 25, 2024
Contributor
Author
|
Ok I think it's done now lol. Pending new reviews |
JstnMcBrd
previously approved these changes
Oct 3, 2024
JstnMcBrd
reviewed
Oct 3, 2024
JstnMcBrd
approved these changes
Oct 3, 2024
Contributor
JstnMcBrd
left a comment
There was a problem hiding this comment.
Excited to see this work when we release v0.13.0!
Contributor
Author
|
Looks like the package was marked private lol, but now that's fixed and I've confirmed that the EDIT: Well something went wrong idk what lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We might as well publish our own Docker image. Would make deployment much easier if a host could simply write
ghcr.io/byu-cs-discord/csbotin acompose.ymlfile, without having to clone and build directly.New Docker deploy flow:
mainx.x.x,x.x,x, andlatestlatestis equivalent to the newest SemVer tag, whilemainis equivalent to the main branchghcr.io/byu-cs-discord/csbot:latestStartup time is a bit slow during command deployment, but we can speed that up later with a smarter deployment solution (one that edits existing commands rather than strict redeploying, which I think would fix the issue with command permissions resetting each time).
Note also that we run database migrations on startup, too.