Fix GitHub Actions script injection vulnerabilities across workflows#1070
Merged
Fix GitHub Actions script injection vulnerabilities across workflows#1070
Conversation
…Actions workflows Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/31e9f14d-f16c-4187-bfde-264193ae0543 Co-authored-by: BYVoid <245270+BYVoid@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code scanning issues for all workflows
Fix GitHub Actions script injection vulnerabilities across workflows
Mar 27, 2026
BYVoid
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub code scanning alert #14 flagged expression injection vulnerabilities where untrusted/user-controlled context values were interpolated directly into
run:scripts via${{ }}, and secrets were exposed inline in Docker command arguments.Changes
release-winget.yml— expression injection in PowerShell scriptsUser-controlled values (
github.event.inputs.version,github.ref_type,github.ref_name,github.repository,steps.version.outputs.value) were embedded directly into PowerShellrun:blocks. Moved all to step-levelenv:and access via$env:VAR:python.yml/release-pypi.yml— secret exposed in Docker command linePYPI_TOKENwas inlined as-e TWINE_PASSWORD=${{ secrets.PYPI_TOKEN }}, putting the secret value in the shell command. Moved to stepenv:and use Docker's environment inheritance:✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.