fix: 控制台 should remain unchanged across all conversion modes#1090
fix: 控制台 should remain unchanged across all conversion modes#1090
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91b01ce7b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b40f45c1e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/da202f5c-3ef4-4481-8650-706aa0df5579 Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
frankslin
force-pushed
the
copilot/update-console-conversion-rule
branch
from
b40f45c to
275f4c4
Compare
「控制台」was being converted to「控制檯」by an
STPhrasesrule, but「控制台」is the correct and preferred form — it should never be converted in any direction.Changes
data/dictionary/STPhrases.txt: Replace控制台 → 控制檯with identity mapping控制台 → 控制台, blocking the character-level台 → 臺fallback in all s2* modesdata/dictionary/HKVariantsRevPhrases.txt: Add identity entry控制台 → 控制台to suppresshk2t's台 → 臺rule (derived fromHKVariants:臺 → 台reversed)test/testcases/testcases.json: Addconsole_stays_unchangedtest covering all 12 conversion modes (s2t,s2tw,s2twp,s2hk,t2s,t2tw,t2hk,tw2s,tw2sp,tw2t,hk2s,hk2t)