Fix 倒霉 incorrectly converting to 倒黴 in S→T conversion#1094
Merged
Conversation
Add 倒霉→倒霉 entry to STPhrases.txt so the phrase-level match overrides the character-level 霉→黴 mapping. The word 倒霉 (unlucky) should not be converted since 霉 here is not the traditional 黴 (mold). Add test case to verify all S→T variants keep 倒霉 unchanged. Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/540cdb84-8557-41d7-8a04-41743a1caee4 Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect translation for 倒霉 to 倒黴
Fix 倒霉 incorrectly converting to 倒黴 in S→T conversion
Apr 11, 2026
frankslin
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The character-level mapping
霉→黴inSTCharacters.txtcauses "倒霉" (unlucky) to incorrectly become "倒黴". The 霉 in 倒霉 derives from 楣 (lintel), not 黴 (mold), so it should remain unchanged.data/dictionary/STPhrases.txt: Add倒霉→倒霉phrase-level entry to override the character-level conversiontest/testcases/testcases.json: Add test case covering s2t, s2tw, s2twp, s2hkWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
releases.bazel.build/usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 test --test_output=errors //data/dictionary:dictionary_test(dns block)If you need me to access, download, or install something from one of these locations, you can either: