Fix incorrect segmentation of 「星露谷物语」 (Stardew Valley) in s2twp mode#1096
Merged
Fix incorrect segmentation of 「星露谷物语」 (Stardew Valley) in s2twp mode#1096
Conversation
Add 星露谷物语→星露谷物語 to STPhrases.txt so the mmseg segmenter matches the full game title as one unit, preventing the incorrect split at 谷物 which was producing 星露穀物語. Add test case covering s2t, s2tw, s2twp, and s2hk conversions. Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/45cee4c8-2eca-49e9-bf5c-06bde0c3ae2a Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix s2twp mode incorrect translation of 星露谷物语
Fix incorrect segmentation of 「星露谷物语」 (Stardew Valley) in s2twp mode
Apr 12, 2026
…y test Agent-Logs-Url: https://github.com/BYVoid/OpenCC/sessions/54c8d576-12c2-4688-a9e5-220c21ad6487 Co-authored-by: frankslin <748873+frankslin@users.noreply.github.com>
frankslin
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
星露谷物语 星露谷物語todata/dictionary/STPhrases.txtstardew_valleytest case totest/testcases/testcases.jsonconsole_stays_unchangedtest case that was accidentally removed